Skip to content

zfs-create(8): ZFS for swap: caution, clarity#16893

Closed
makhomed wants to merge 2 commits intoopenzfs:zfs-2.1-releasefrom
makhomed:zfs-2.1-release
Closed

zfs-create(8): ZFS for swap: caution, clarity#16893
makhomed wants to merge 2 commits intoopenzfs:zfs-2.1-releasefrom
makhomed:zfs-2.1-release

Conversation

@makhomed
Copy link
Copy Markdown

@makhomed makhomed commented Dec 20, 2024

zfs-create(8): ZFS for swap: caution, clarity

Make the section heading more generic (the section relates to ZFS files as well as ZFS volumes).

Swapping to a ZFS volume is prone to deadlock. Remove the related instruction, direct readers to OpenZFS FAQ. Related, but not linked from within the manual page:

https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux (Using a zvol for a swap device on Linux).

Motivation and Context

Fixes issue #16891

Description

Backport patch from 6c29422 to branch 2.1-release

How Has This Been Tested?

man page updated only, no code changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@makhomed
zfs-create(8): ZFS for swap: caution, clarity
5744d89 
zfs-create(8): ZFS for swap: caution, clarity
Make the section heading more generic (the section relates to ZFS files
as well as ZFS volumes).

Swapping to a ZFS volume is prone to deadlock. Remove the related
instruction, direct readers to OpenZFS FAQ. Related, but not linked
from within the manual page:

<https://openzfs.github.io/openzfs-docs/Project%20and%20Community/FAQ.html#using-a-zvol-for-a-swap-device-on-linux>
(Using a zvol for a swap device on Linux).

Signed-off-by: Hennadii Makhomed <makhomed@gmail.com>
@makhomed
Merge pull request #1 from makhomed/zfs-2.1-release-zfs-create-man-up…
61e687f 
…date

zfs-create(8): ZFS for swap: caution, clarity
@gmelikov
Copy link
Copy Markdown
Member

gmelikov commented Dec 22, 2024

@makhomed such backports should be at least as git cherry-pick with all info about original authors (see that full commit message is here with original authors https://github.com/openzfs/zfs/pull/16781/commits ) , and let's add info about 2.1 release into PR title. And "Merge pull request" is not needed here too, you may drop it.

@amotin amotin requested a review from tonyhutter December 26, 2024 19:47
@tonyhutter
Copy link
Copy Markdown
Contributor

tonyhutter commented Dec 26, 2024 •
edited
Loading

@makhomed I just created a new zfs-2.1.17-staging branch you can open this PR against. You can go to 'Edit' at the top of the PR and change the destination branch to openzfs:zfs-2.1.17-release.

That said, it unlikely we'll do another 2.1.x release (although not impossible). We only released 2.1.16 to fix a build problem. If you want to continue with this PR, you'll want to get rid of the merge commit as @gmelikov mentioned.

@makhomed makhomed closed this by deleting the head repository Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyhutter tonyhutter Awaiting requested review from tonyhutter

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@makhomed @gmelikov @tonyhutter